-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sublime-syntax.json #3010
add sublime-syntax.json #3010
Conversation
Fixed. |
Add URL, pattern, descriptions. |
@Freed-Wu, you can also add completion for some common scopes using this technique:
P.S. to fix issue with build failure change |
Add extension for test sublime syntax. Remove addionalProperties to permit any not common scopes. |
Fixed. |
Can scope name have some recommended values? https://www.sublimetext.com/docs/scope_naming.html lists the recommend values for many scope names and corresponding documents. |
Is this ready to be merged? |
Can we provide a description for every scope?
If any recommended value for scope is not recommended, it should be enough. |
@Freed-Wu I'm not sure. What comes to mind is something like this: {
"oneOf": [
{
"type": "string",
"enum": ["scope1"],
"description": "Description 1"
},
{
"type": "string"
"enum": ["scope2"],
"description": "Description 2"
},
{
"type": "string"
}
]
} But I'm not sure if it actually works, you can test if it does, though. |
@Freed-Wu My earlier comment seems incorrect, I have recently found out that you need to use |
It is hard because https://github.com/vuejs/vue-syntax-highlight/tree/HTML.yaml#L280: # ...
contexts:
# ...
style-type-attribute:
- match: (?i)\btype\b
scope: meta.attribute-with-value.html entity.other.attribute-name.html
set:
- meta_content_scope: meta.tag.style.begin.html meta.attribute-with-value.html
- match: =
scope: punctuation.separator.key-value.html
set:
- meta_content_scope: meta.tag.style.begin.html meta.attribute-with-value.html
- include: style-type-decider
- match: (?=\S)
set: style-css That is, if we want to recommend scope_a, scope_b, scope_c, any combination of scope_a, scope_b, scope_c is legal. |
Co-authored-by: Keith Hall <[email protected]>
This PR is stale because it has been open 60 days with no activity. Comment or this will be closed in 7 days. |
CI was failing because AJV Strict Mode caught multiple errors in the schema. I have made fixes and I will merge the result unless anybody thinks otherwise |
Co-authored-by: Keith Hall <[email protected]> Co-authored-by: Edwin Kofler <[email protected]>
sublimehq/sublime_text#6023